revert: remove dynamic plugin loading (#303) - #335
Open
lshoravi wants to merge 1 commit into
Open
Conversation
The plugin feature cannot work as designed. scheme-rs is an rlib with no [lib] section, so a cdylib plugin depending on it by path statically links its own copy of the crate — and therefore its own `static HEAP`, its own collector thread, its own symbol interner and its own runtime. Values allocated inside a plugin are then freed by the host's collector, which splices its intrusive heap list against a list head from a different heap. Reverting the feature rather than patching it: making it sound requires either a C ABI boundary or a shared-dynamic-runtime build, both of which are design decisions in their own right. Removed by hand rather than with `git revert` because maplant#330/maplant#331 touched the same files afterwards; this preserves that work.
lshoravi
marked this pull request as ready for review
August 1, 2026 09:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #303 on top of current main. Plugins install double heaps and allocate separately, never getting cleaned up and occasionally corrupts memory.