Performance changes - #32
Open
ajinkya-kulkarni wants to merge 1 commit into
Open
ajinkya-kulkarni wants to merge 1 commit into
ajinkya-kulkarni wants to merge 1 commit into
Conversation
1. downsample_image(): Added a default value of "numpy" for the mode argument. Changed the conversion from PIL image to numpy array to remove the alpha channel. 2. bg_color_identifier(): Simplified the computation of the number of lines for the background selection. Changed the output format of the function to return bord_unique alongside bg_color as another possible candidate for background color. 3. selector_otsu(): Simplified the code by using np.mean() instead of np.sum() and dividing by the total number of pixels. This provides a more direct measure of the proportion of background pixels. Simplified the if/else statement at the end to remove redundancy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downsample_image(): Added a default value of "numpy" for the mode argument. Changed the conversion from PIL image to numpy array to remove the alpha channel.
bg_color_identifier(): Simplified the computation of the number of lines for the background selection. Changed the output format of the function to return bord_unique alongside bg_color as another possible candidate for background color.
selector_otsu(): Simplified the code by using np.mean() instead of np.sum() and dividing by the total number of pixels. This provides a more direct measure of the proportion of background pixels. Simplified the if/else statement at the end to remove redundancy.