Skip to content

fix: repair orphaned nodes in hnsw graph after construction #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glookka merged 1 commit into from
Sep 3, 2026
+999 −1
Merged

fix: repair orphaned nodes in hnsw graph after construction #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion knn/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,22 @@ cmake_minimum_required ( VERSION 3.21 ) # because of IMPORTED_RUNTIME_ARTIFACTS

include ( GetHNSW )

add_library ( knn_lib MODULE knn.cpp knn.h iterator.cpp iterator.h embeddings.cpp embeddings.h quantizer.cpp quantizer.h quantile.cpp quantile.h space.cpp space.h termination.cpp termination.h ${columnar_SOURCE_DIR}/embeddings/manticoresearch_text_embeddings.h )
set ( KNN_SOURCES knn.cpp knn.h iterator.cpp iterator.h embeddings.cpp embeddings.h quantizer.cpp quantizer.h quantile.cpp quantile.h space.cpp space.h termination.cpp termination.h graphrepair.cpp graphrepair.h )

add_library ( knn_lib MODULE ${KNN_SOURCES} ${columnar_SOURCE_DIR}/embeddings/manticoresearch_text_embeddings.h )
target_include_directories(knn_lib PRIVATE ${columnar_SOURCE_DIR}/embeddings)

target_link_libraries ( knn_lib PRIVATE hnswlib::hnswlib columnar_root util common )
set_target_properties( knn_lib PROPERTIES PREFIX "" OUTPUT_NAME lib_manticore_knn${lib_arch_suffix} )

# Regression test for the HNSW connectivity repair pass. Links the knn sources directly it can reach graphrepair.h (internal, not part of the exported C ABI)
if ( NOT EXTERNAL_LIB AND BUILD_TESTING )
add_executable ( knn_graphrepair_test test_graphrepair.cpp ${KNN_SOURCES} )
target_include_directories ( knn_graphrepair_test PRIVATE ${columnar_SOURCE_DIR}/embeddings ${CMAKE_CURRENT_SOURCE_DIR} )
target_link_libraries ( knn_graphrepair_test PRIVATE hnswlib::hnswlib columnar_root util common )
add_test ( NAME knn_graphrepair COMMAND knn_graphrepair_test )
endif()

# Try to find manticoresearch text embeddings library
message(STATUS "Looking for manticoresearch text embeddings library...")

Expand Down
Loading