Merging Reg-Free Com attributes - #67
Merged
Merged
Conversation
Owner
|
Many thanks! I'll review this today and get t merged |
Owner
|
Thanks @motisoft , merged. Took me a while to figure out how to get the workflow to run, I usually use Azure DevOps at work - yours is actually the first community PR I've ever had on GitHub. I'm hoping to do some updates to this project soon, will look to add file scanning and expose the new option in ADO pipelines then, Thanks again :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this addresses #16 and #23.
i did not added the MergeCom flag to the azure devops task.
i used detection of .manifest based on the file name.
it could be improved by searching for some extension like *.com.manifest and then match the file names from them with the existing targets in the manifest, which is what i do today after creating manifests with mt.exe.