Add isolated scene renderer libraries - #198
Draft
lawrencecchen wants to merge 27 commits into
Draft
Conversation
…378-terminal-backend-main # Conflicts: # src/apprt.zig # src/apprt/embedded.zig # src/config/CApi.zig # src/config/Config.zig # src/config/theme.zig # src/main_c.zig # src/renderer/Metal.zig # src/renderer/generic.zig # src/renderer/metal/Frame.zig # src/renderer/metal/Target.zig # src/renderer/opengl/Frame.zig # src/terminal/kitty/graphics_exec.zig # src/terminal/kitty/graphics_storage.zig
…378-terminal-backend-main-v2 # Conflicts: # include/ghostty.h # include/ghostty/vt/terminal.h # src/terminal/c/terminal.zig
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Parent: manaflow-ai/cmux#8378
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds isolated config and semantic-scene renderer libraries for cmux’s out-of-process rendering. Hardens isolation by failing closed over process syscalls (
fork/execve) and rejecting process I/O at runtime.New Features
ghostty_scene.h+GhosttySceneRendererKitXCFramework with a single-threaded C API, frame-lease events, IOSurface provenance/ID export, and health reporting. Metal-only with strict capability checks (no process/PTY/app/surface/parser/dynamic-loader access).ghostty_config.h+GhosttyConfigKitXCFramework for file discovery, recursive loads, finalization, and canonical serialization (no CLI/app/PTY/parser/render APIs).ghostty/vt/render_scene.hwith cached canonical deltas and bounded limits.ghostty_key_from_macos_keycodefor layout-independent input in separate processes.fork/execvereturnENOTSUP) with a linkage probe; scene I/O vtable rejects process operations at runtime.Dependencies
-Demit-scene-xcframework=true,-Demit-config-xcframework=true, and-Demit-lib-vt-shared(native-only shared lib toggle).scene_renderer_onlyandconfig_onlyroots; main Ghostty app remains unchanged.Written for commit 825c6bd. Summary will update on new commits.