Remove SwiftUI from GhosttyKit - #180
Open
lawrencecchen wants to merge 15 commits into
Open
Conversation
|
Important Review skippedToo many files! This PR contains 132 files, which is 32 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. 鈿欙笍 Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 馃搾 Files selected for processing (132)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the remaining SwiftUI dependency from GhosttyKit test support and enables strict Swift 6 concurrency checking for the embedded framework.\n\nVerification: strict-concurrency macOS and iOS framework builds completed on the cmux fleet builder.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Make the macOS app AppKit-only and enforce strict Swift 6 concurrency across Apple targets. This removes SwiftUI and Shortcuts/App Intents, replaces remaining declarative views with native ones, and keeps automation via Apple events, Services, and CLI.
Refactors
UniformTypeIdentifiers; AppleScript commands bridge to the main actor with safenonisolatedoverrides.swift-tools-version: 6.2with.swiftLanguageMode(.v6)and upcoming features), added@MainActor/nonisolated/isolated deinits, replaced timers with tasks, used@preconcurrencyimports and lightweight Sendable wrappers; README updated to reflect AppKit and automation.UIApplicationDelegate+ scenes (UIKit) and builds under Swift 6.Migration
Written for commit ea4fcc9. Summary will update on new commits.