Repository navigation
ci: run CI on release pull requests so main can require it - #5
Merged
Merged
Conversation
main now requires the CI checks on every pull request. GitHub does not run workflows for pull requests opened by GitHub Actions, so the release workflow starts CI on release-please's branch with workflow_dispatch, the one event the workflow token may trigger. Document the merge rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main now requires the CI checks (
Check (macos-15),Check (ubuntu-latest)) on every pull request, with no required approvals for maintainers.GitHub does not run workflows for pull requests opened by GitHub Actions, so release-please's pull request would never get those checks. The release workflow now starts CI on the release branch with
workflow_dispatch, the one event the workflow token may trigger, so release pull requests merge like any other.CONTRIBUTING documents the merge rules.