Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefix automatic SDK download filenames with the returned project ID so separate projects whose output URLs share a basename do not overwrite one another. All eight image/video/audio/face-detection sync/async callers pass that ID through the existing downloader; direct helper calls without it retain their previous naming. README calls out the filename change and
downloaded_pathsas the authoritative saved paths.Six files, 23 insertions / 3 deletions. Independent exact-source review passed. On devbox, all 169 existing Python3.12 tests passed in 35.22 seconds; mypy over 241 source files, existing parameter-sync and whitespace checks passed. Direct execution of the existing path helper returned
./project-a-0.mp4and./project-b-0.mp4for two projects sharing the URL basename; omitting the optional ID retained./0.mp4. These were path computations, not new download fixtures or live media transfers; existing suites do not cover cross-project collisions. No tests, fixtures, dependencies, HTTP options, directory creation policy, polling cadence or error semantics changed. Same-project re-download and duplicate basenames within a project can still overwrite; this is not universal collision prevention. Main-based and independently shippable, not stacked on polling-options PR183.