Skip to content

fix: keep generated workflow arguments valid - #164

Merged
davidhu2000 merged 2 commits into
mainfrom
codex/fix-face-detection-sample
Sep 5, 2026
Merged

davidhu2000 merged 2 commits into
mainfrom
codex/fix-face-detection-sample

Conversation

@runshouse

@runshouse runshouse commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Why

The generated Face Detection generate() examples omit a comma before the SDK-only workflow parameters, so the published Python snippet is invalid.

What changed

  • make the docs generator add a missing trailing comma before appending workflow parameters
  • preserve calls that already end in a comma
  • repair the current sync and async Face Detection examples
  • no tests, packages, dependencies, screenshots, or generated artifacts added

Validation

  • existing full test suite: 163 passed
  • mypy magic_hour
  • compiled the changed generator
  • parsed every Python example in the corrected Face Detection README
  • git diff --check

@davidhu2000
davidhu2000 merged commit 45780e1 into main Sep 5, 2026
6 checks passed
@davidhu2000
davidhu2000 deleted the codex/fix-face-detection-sample branch September 5, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants