Add classes for better dummies encoding, flags for missing data, and missing data replacement - #3
Open
brettasmi wants to merge 14 commits into
Open
Add classes for better dummies encoding, flags for missing data, and missing data replacement#3brettasmi wants to merge 14 commits into
brettasmi wants to merge 14 commits into
Conversation
…peated calls to .fit()
…, NanReplacer, and MissingIndicator
… repeated .fit() calls
… different dtypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the DummiesEncoder, MissingIndicator, and NanReplacer classes to dftransformers.py.
They seem to work well at this point and be robust to np.nan of different dtypes (which I spent yesterday tearing my hair out over). This code was a lot cleaner until I had to add lots of special nan handling. There are still some issues to work out and features to add including: