Repository navigation
release 0.32.0: the A0 re-seal, and what this release does not change - #29
Merged
Merged
Conversation
The native library is pinned to macula-go v0.29.0, the release that carries the A0 contract: a call a keyed provider refuses sealed_required is resealed to the key in the refusal's signed tbs and answered, instead of failing on a stale keyless candidate. The changelog states what 0.32.0 does not change as well as what it does: sealing is the default where the provider names a KEM key and only there (a provider that names none is still called clear), refusing a clear call unless the caller opts out is not in this release, and on the serving side a procedure served with no policy is still advertised open (macula-ts#27). Refs macula-ts#24, macula-ts#27.
…opt-in Review of #29, three required fixes: - unary serve serves any caller with no policy, exactly as serveStream does (pool.ts:381-386, serveOptionsJson drops an undefined policy, and macula-go's cabi/serve.go reads nil as open). The note said only the streaming side; it now says both, and the unary twin is filed as macula-ts#30. - a provider names a KEM key only with kemAdvertise: 1, off by default, so two pools on default options talk in the clear. Without that clause "sealing is the default" reads as more than the release does. - package-lock.json still carried 0.31.0 in both places the release commit sets. Refs macula-ts#24, macula-ts#27, macula-ts#30.
Review of #29, r=2: the release note named an option that does not exist, so a reader copying it would have set nothing and silently got the default. Refs macula-ts#24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs macula-ts#24, macula-ts#27.
Proposed tag: v0.32.0 (from 0.31.0; the A0 pin changes behaviour on the wire, so a minor bump).
No tag, no publish.