Repository navigation
release 0.6.0: the A0 re-seal, and what this release does not change - #19
Merged
Merged
Conversation
The native library is pinned to macula-go v0.29.0, the release that carries the A0 contract: a call a keyed provider refuses sealed_required is resealed to the key in the refusal's signed tbs and answered, instead of the caller failing on a stale keyless candidate. pyproject already says 0.6.0 and the version was never tagged, so the entry goes into the 0.6.0 section rather than a new one, with a subsection for what landed after it was written. What this release does not change is stated too: sealing stays preferred, not required, and a stream served with no policy is still advertised open (macula-py#18). Refs macula-py#15, macula-py#18.
…eeds an opt-in The two corrections the php round needed, made here before review rather than after it: the 0.6.0 intro said libmacula is macula-go v0.27.0 while the pin is v0.29.0, so the intro names v0.29.0 with the flag-day version as history and the heading carries the release day; and a pool names a KEM key only with kem_advertise=True, off by default (src/macula_py/pool.py:483), so two pools on default arguments talk in the clear. The open default is stated for both shapes: serve and serve_stream take policy as an optional keyword (macula-py#18 covers streams; the unary twin has no issue yet and the Supervisor has that question). Refs macula-py#15, macula-py#18.
macula-py#20 is the unary twin of #18, filed from the source: serve takes policy as an optional keyword and libmacula serves any caller without one. The note points at both. Refs macula-py#18, macula-py#20.
…otated key Review of #19: the paragraph gave the wrong cause. sealed_required comes from a caller holding a KEYLESS advertisement and calling clear; a caller holding an old key gets sealed_refused, with the current key id in detail. Reworded to match the changelog bullet and the mechanism. Refs macula-py#15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs macula-py#15, macula-py#18.
Proposed tag: v0.6.0 (pyproject already carries 0.6.0 and no v0.6.0 tag exists; the last tag is v0.6.0rc4).
No tag, no publish.