Repository navigation
fix(teststation): listen with a live station's idle timeout and keepalive - #63
Merged
Merged
Conversation
…live The teststation listened with quic-go's default 30 s idle timeout and no keepalive, so every client dialling it got 30 s instead of the fleet's 300 s with a 15 s keepalive, and a path-outage test failed for a reason production does not share (macula-rust#57). transport now names the two values once (IdleTimeout, KeepAlivePeriod), the client dial and the teststation listener both use them, and a test reads the advertised idle timeout and a keepalive PING off the wire. Refs #62 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #62
The teststation listened with quic-go's default 30 s idle timeout and no keepalive. Live stations use 300 s with a 15 s keepalive (
macula_quicdefaults), so a path-outage test failed on the teststation for a reason production does not share (macula-rust#57).transportnames the two values once:IdleTimeout(300 s) andKeepAlivePeriod(15 s). The client dial config is built from them.TestTheStationKeepsALiveStationsIdleTimeoutAndKeepalivedials with a 1 h idle timeout and no keepalive of its own. It reads off the client's qlog that the station advertises 300 s and sends a PING after about 15 s of silence. Against origin/master's station both checks fail: it advertises 30 s and sends no keepalive within 20 s. The test adds about 15 s togo test ./teststation.🤖 Generated with Claude Code