Repository navigation
release 0.9.0: the A0 re-seal, and what this release does not change - #26
Merged
Merged
Conversation
libmacula is pinned to macula-go v0.29.0, the release that carries the A0 contract: a call a keyed provider refuses sealed_required is resealed to the key in the refusal's signed tbs and answered, instead of the caller failing on a stale keyless candidate. The 0.9.0 intro said v0.27.0 while the pin is v0.29.0, and the heading was dated the flag day on a release first tagged now. Both fixed, with v0.27.0 kept as history. The note states what does not change as well: KemAdvertise is off by default (src/Macula/Pool.cs:42), so two pools on default options talk in the clear, and a procedure served with no policy is advertised open, unary and streaming alike (macula-dotnet#24, macula-dotnet#25). Refs macula-dotnet#21, macula-dotnet#24, macula-dotnet#25.
…ted key The paragraph as first written gave the wrong cause: sealed_required comes from a caller holding a KEYLESS advertisement and calling clear, while a caller holding an old key gets sealed_refused with the current key id in detail. Caught in the macula-py review of the same sentence before this branch was reviewed. Refs macula-dotnet#21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs macula-dotnet#21, macula-dotnet#24, macula-dotnet#25.
Proposed tag: v0.9.0. Macula.csproj already carries 0.9.0 and the last tag is v0.9.0-rc.5, so the version needs no bump.
dotnet build -c Releasegreen locally (0 warnings, 0 errors). No tag, no publish.