Change Result content class variable - #6
Conversation
|
Thanks! Could you please add |
|
Yes, I can add that. Are you open to deprecating the getContent method on the next major release as a breaking change? The API will get muddy if we're always backwards supporting these calls. I was confused initially by the different getByIds and byIds for example on the Match class. |
|
Some people prefer the I don't really see the point of deprecating just one method, also I'm not sure when or if there will be a major release as I currently don't have much time and it is unlikely that Riot's API will drastically change in the future |
|
I prefer the get prefix. Everything can have the get prefix, but then we don't have to have double the function calls. It's confusing to have functions with get and without get that do the same thing. The point is to keep this API concise, UX friendly, and less confusing. You are right about Riot most likely not drastically changing the API in the near future, but that doesn't mean this package can't have releases. |
Fixed class not found when trying to run unit tests.
Change Result to set data instead of content so both BatchResult and Result classes use the same property.