Repository navigation
Conversation
The TimerWidget's StaticHeader (icon, title, buttons, background) was being rebuilt and re-sent every 300ms during dynamic timer mode, even though only the countdown text changes between ticks. Split the widget into two manialink layers: - Header layer (this.id): rebuilt only on state changes (dynamic toggle, pause/resume, position change, map events) - Time layer (this.id + 4): rebuilt every 300ms tick This eliminates ~75-80% of the per-tick XML payload and avoids redundant StaticHeader.constructXml() + getButtonsXml() string building on every interval fire.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TimerWidget's StaticHeader (icon, title, buttons, background) was being rebuilt and re-sent every 300ms during dynamic timer mode, even though only the countdown text changes between ticks.
Split the widget into two manialink layers:
This eliminates ~75-80% of the per-tick XML payload and avoids redundant StaticHeader.constructXml() + getButtonsXml() string building on every interval fire.