Verify coding-engine capabilities before dispatch by prasadus92 · Pull Request #592 · luminik-io/alfred

prasadus92 · 2026-07-24T04:58:28Z

What changed

add a canonical engine capability registry for Claude Code, Codex, OpenCode, and Cline
require protocol and authentication checks before an engine is eligible for autonomous dispatch
keep detected but unvalidated harnesses visible without presenting them as ready
expose honest readiness details in onboarding and settings
prevent unrelated credentials from crossing engine probe subprocess boundaries
require Codex dispatches to ignore unrelated user configuration and avoid session persistence

Verification

full Python test suite
Ruff 0.15.22 formatting and lint checks
mypy 2.3.0
desktop type checks, lint, tests, production build, and built-app contract tests
site tests
public metadata scrub
real Codex wrapper smoke test under read-only sandbox
independent blocker review: clean

prasadus92 · 2026-07-24T04:59:25Z

@codex review

prasadus92 · 2026-07-24T04:59:26Z

@greptileai review

greptile-apps · 2026-07-24T05:06:06Z

Greptile Summary

Adds a canonical coding-engine readiness contract and enforces it across setup, diagnostics, and dispatch.

Registers Claude Code, Codex, OpenCode, and Cline capabilities while limiting autonomous dispatch to validated engines.
Verifies CLI protocol, version, and authentication before real Claude or Codex invocation.
Reports detailed readiness states through the CLI, server setup API, onboarding, and settings.
Isolates probe subprocess environments and runs Codex without unrelated user configuration or session persistence.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failures remain.

T-Rex Logs

What T-Rex did

T-Rex ran the pre-check and observed a fail-closed protocol gate that blocked dispatch.
T-Rex performed the post-check and observed readiness with real-process invocation succeeding.
T-Rex captured a sanitized argv and environment trace for all child processes to verify isolation.
T-Rex included a reproducibility harness and an executable wrapper to support repeatable runs.

_{Ran code and verified through T-Rex}

Important Files Changed

Filename	Overview
lib/agent_runner/engine_registry.py	Introduces canonical engine descriptors, capability metadata, sanitized protocol probes, authentication checks, and bounded readiness caching.
lib/agent_runner/process.py	Gates real Claude and Codex adapters on readiness and adds hermetic, ephemeral Codex invocation flags.
lib/agent_runner/config.py	Derives supported engine choices from the registry and converts invalid operator configuration into a non-dispatching state.
lib/server/setup.py	Replaces executable-presence detection with canonical readiness inventory in setup status.
bin/alfred	Adds engine diagnostics and discovers configured engine-aware agents from deployed scheduler state.
clients/desktop/src/components/onboarding/EngineStep.tsx	Distinguishes detected engines from compatible, authenticated engines and exposes detailed probe states.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Config[Configured engine] --> Registry[Capability registry]
  Registry --> Probe[Protocol, version, and auth probe]
  Probe -->|Ready| Dispatch[Engine adapter dispatch]
  Probe -->|Not ready| Failure[Structured readiness failure]
  Registry --> Setup[Setup API and desktop readiness UI]
  Registry --> Doctor[CLI engine doctor]

_{Reviews (10): Last reviewed commit: "fix engine readiness and doctor roster p..." | Re-trigger Greptile}

greptile-apps · 2026-07-24T05:06:35Z

Greptile Summary

Adds a canonical coding-engine capability registry and exposes protocol/authentication readiness throughout setup and desktop surfaces.

Adds bounded, scrubbed probes for Claude Code, Codex, OpenCode, and Cline.
Uses readiness rather than binary presence for setup and conversational engine discovery.
Expands onboarding/settings types, presentation, tests, and routing documentation.
Makes unknown configured engine identifiers fail closed.

Confidence Score: 2/5

This should not merge until autonomous dispatch enforces engine readiness and Codex authentication is not inferred from API-key presence alone.

Scheduled runners still invoke engines after binary-only preflight, while an arbitrary nonempty OPENAI_API_KEY marks Codex ready and routes work to it before real authentication occurs.

lib/agent_runner/config.py, lib/agent_runner/engine_registry.py, and lib/agent_runner/process.py

T-Rex Logs

What T-Rex did

Reproduced readiness bypass by exercising the isolated fake Codex binary: it passed protocol preflight but failed its authentication probe with ready=false and state=auth_required, yet the repository invocation dispatched the engine and the regression harness exited with an error.
Validated key presence bypasses Codex authentication: without a real API key the canonical probe observed auth failure and ready=false, while with a placeholder key the probe skipped login and reported ready=true and a signed-in state, with endpoint status transitioning from not-ready to signed-in and engine_ready true.
Compared readiness UI across builds and verified visual runs: before, the engine appeared installed with no ready engine and authentication details; after, the engine remains visible with sign-in indicators and engine readiness updated to ready, with both visual runs passing and archives validated.

_{Ran code and verified through T-Rex}

Important Files Changed

Filename	Overview
lib/agent_runner/engine_registry.py	Introduces canonical engine probes, but Codex treats any nonempty API key as authenticated without validating it.
lib/agent_runner/config.py	Derives engine choices from the registry, but autonomous preflight still reduces capability validation to binary presence.
lib/server/setup.py	Replaces presence-only setup detection with the canonical readiness inventory and propagates readiness details.
lib/compose_converse.py	Limits automatically selected conversational engines to probe results marked ready, including falsely ready Codex results.
clients/desktop/src/components/onboarding/EngineStep.tsx	Distinguishes installed, compatible, authenticated, and unvalidated engine states in onboarding.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Registry[Engine capability registry] --> Probe[Protocol and auth probes]
  Probe --> Setup[Setup status]
  Setup --> Desktop[Onboarding and settings]
  Setup --> Converse[Conversation engine discovery]
  Config[Scheduled agent configuration] --> Preflight[Binary-only preflight]
  Preflight --> Invoke[Autonomous engine invocation]
  Probe -. readiness not enforced .-> Preflight

_{Reviews (1): Last reviewed commit: "feat(engines): verify harness capabiliti..." | Re-trigger Greptile}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c9d8d2f79

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-24T05:47:59Z

@codex review

prasadus92 · 2026-07-24T05:48:00Z

@greptileai review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a823e35b7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-24T06:16:36Z

@codex review

prasadus92 · 2026-07-24T06:16:37Z

@greptileai review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddf7aa8bcb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-24T06:35:23Z

@codex review

prasadus92 · 2026-07-24T06:35:24Z

@greptileai review

chatgpt-codex-connector · 2026-07-24T06:35:42Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b7f438390

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-24T06:49:14Z

@codex review

chatgpt-codex-connector · 2026-07-24T06:49:34Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-24T06:55:26Z

@codex review

chatgpt-codex-connector · 2026-07-24T06:55:43Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f94a7c98b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-24T09:21:19Z

@greptile review

prasadus92 · 2026-07-24T10:17:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82862e6cf5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-24T10:56:22Z

@greptile review

prasadus92 · 2026-07-24T10:56:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce32095866

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-24T11:40:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce32095866

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-24T21:47:58Z

@greptile review

Exact head: be38f4fd6b12bc42406d8c0c69aa2acbc11893bd

prasadus92 · 2026-07-24T21:47:59Z

@codex review

Exact head: be38f4fd6b12bc42406d8c0c69aa2acbc11893bd

chatgpt-codex-connector · 2026-07-24T21:52:42Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: be38f4fd6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-25T03:13:59Z

@greptile review

Exact head: be38f4fd6b12bc42406d8c0c69aa2acbc11893bd

prasadus92 · 2026-07-25T07:38:41Z

@greptileai review

Please review exact HEAD be38f4fd6b12bc42406d8c0c69aa2acbc11893bd.

prasadus92 · 2026-07-25T13:29:18Z

@codex review

prasadus92 · 2026-07-25T13:29:19Z

@greptileai review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71cbd0b6e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-25T14:22:36Z

@codex review

prasadus92 · 2026-07-25T14:22:37Z

@greptileai review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3980812d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-25T15:07:21Z

@codex review

prasadus92 · 2026-07-25T15:07:22Z

@greptileai review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 381b547fb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prasadus92 · 2026-07-28T19:44:59Z

@codex review

prasadus92 · 2026-07-28T19:45:23Z

@greptileai review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e67d954bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-28T19:49:22Z

+                markers=(
+                    "--output-last-message",
+                    "--sandbox",
+                    "--cd",
+                    "--skip-git-repo-check",
+                    "--ignore-user-config",
+                    "--ephemeral",
+                    "-c",
+                ),


Probe every Codex option used at dispatch

When a Codex CLI or wrapper exposes the options checked here but lacks --add-dir or --dangerously-bypass-approvals-and-sandbox, this probe reports it ready even though codex_invoke later supplies those options. This affects concrete fleet paths: the planner supplies both options, while the reviewer and senior developer supply --add-dir, so they fail only after dispatch instead of being rejected by the readiness gate. Include every dispatched option in the exec --help markers, including --model if configured models are supported.

Useful? React with 👍 / 👎.

feat(engines): verify harness capabilities before dispatch

9c9d8d2

greptile-apps Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/config.py

Comment thread lib/agent_runner/config.py

Comment thread lib/agent_runner/engine_registry.py

greptile-apps Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/config.py

Comment thread lib/agent_runner/engine_registry.py Outdated

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/engine_registry.py Outdated

fix(engines): gate dispatch on verified readiness

a823e35

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/config.py

greptile-apps Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/process.py Outdated

fix(engines): enforce readiness at adapter boundary

ddf7aa8

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/engine_registry.py Outdated

Comment thread lib/agent_runner/engine_registry.py

test(engines): isolate adapter readiness probes

4b7f438

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/engine_registry.py

test(engines): patch owned adapter during isolation

5f94a7c

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/process.py

fix(engines): align readiness with real auth

0278472

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/engine_registry.py Outdated

fix(engines): require Claude auth status support

ce32095

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/engine_registry.py Outdated

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread lib/agent_runner/process.py

fix(engines): close readiness edge cases

be38f4f

fix: align Codex probes with isolated dispatch

71cbd0b

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread lib/agent_runner/process.py Outdated

fix: retry transient engine probes

c398081

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread lib/agent_runner/engine_registry.py Outdated

fix: retry failed protocol probes

381b547

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread lib/agent_runner/process.py

fix engine readiness and doctor roster parity

1e67d95

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Uh oh!

Conversation

prasadus92 commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Verification

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

greptile-apps Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

T-Rex Logs

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 24, 2026

Greptile Summary

Confidence Score: 2/5

T-Rex Logs

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 24, 2026

Uh oh!

prasadus92 commented Jul 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

prasadus92 commented Jul 24, 2026 •

edited

Loading

greptile-apps Bot commented Jul 24, 2026 •

edited

Loading