💄 Stop text-link forcing the brand color on colored surfaces - #3319
Open
posthog-eu[bot] wants to merge 1 commit into
Open
posthog-eu[bot] wants to merge 1 commit into
posthog-eu[bot] wants to merge 1 commit into
Conversation
The text-link utility applies the space's brand color (text-primary), which is customer-chosen through white-label branding. On a colored or component- owned surface the brand color is unpredictable and can fail contrast. Add a text-link-inherit variant that inherits the surface text color, and move the three call sites on colored or component-owned surfaces onto it: the self-hosted license limit warning, the rich text editor, and the markdown description. Also drop Alert's link hover:text-foreground, which replaced the alert's own colored text with the global foreground on hover. Generated-By: PostHog Desktop Task-Id: 264d9cb8-0cd1-4989-bd3b-2e8d6d35d14f
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: lukevella/rallly/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lukevella
marked this pull request as ready for review
September 19, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
text-linkutility paints every link in the space's own brand color (text-primary). That token is customer-chosen through white-label branding, so on a colored or component-owned surface the link color is one the surface never accounted for and can fail contrast.Why: a latent accessibility risk. A branded or self-hosted space can pick a brand color that fails contrast against a colored surface, and the next person to reach for
text-linkinside anAlertinherits the defect.Changes:
Add a
text-link-inheritvariant that inherits the surface text color (text-current) instead of the brand color. Same focus ring and hover underline astext-link.Move the three call sites on colored or component-owned surfaces onto it:
features/licensing/components/license-limit-warning.tsxbg-mutedpackages/ui/src/rich-text-editor.tsxpackages/ui/src/markdown-description.tsxDrop
Alert's[&_a]:hover:text-foreground. On a colored variant it replaced the alert's own text color (e.g.text-yellow-900) with the global foreground on hover. Links now keep the alert's own color; the always-present underline stays as the affordance.Neutral surfaces keep
text-linkand the brand color as before.Checklist
Please check off all the following items with an "x" in the boxes before requesting a review.
Created with PostHog Desktop from this inbox report.