Repository navigation
build: move the pinned toolchain to Flutter 3.47.5 - #82
Merged
Merged
Conversation
Bump the SDK every tool reads: .fvmrc for local fvm and the CI jobs that derive from it, the license check's separately pinned flutter_version, and the pre-push hook's comment naming the version. The pubspec's flutter lower bound is left alone. It constrains the package's consumers, not this repository's toolchain. Flutter 3.47's tooling added build/ and web/ to the analyzer excludes on first run; those edits are kept, since they only stop the analyzer from reading generated output. Verified on 3.47.5 (Dart 3.13.4): format, analyze and tests pass for the package and every sub-package, and the published site still builds with --wasm. Line coverage is unchanged from 3.44.0.
Two diagnostics are new under the 3.47.5 analyzer, and each blocks flutter analyze: - unnecessary_unawaited in FlowinChipGroupViewPager: 3.47 annotates PageController.animateToPage with @awaitNotRequired, so wrapping it in unawaited is now redundant. The call is unchanged at runtime. - matching_super_parameters in the showcase's ThemeModeController: ValueNotifier's positional parameter is now named _value, so the super parameter takes that name. Spelling it out as super(initial) instead trips use_super_parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the pinned toolchain from Flutter 3.44.0 to 3.47.5 (Dart 3.13.4):
.fvmrc, which localfvmand the CI jobs read, the license check's separately pinnedflutter_version, and the pre-push hook's comment naming the version.The pubspec's
flutter: ">=3.41.0"lower bound is unchanged. It constrains the package's consumers, not this repository's toolchain, so no release is needed.Flutter 3.47's tooling added
build/**andweb/**to the analyzer excludes on first run. Those edits are kept, since they only stop the analyzer from reading generated output.Two lints are new under the 3.47.5 analyzer and each fails
flutter analyze, so they are fixed here:unnecessary_unawaitedinFlowinChipGroupViewPager: 3.47 annotatesPageController.animateToPagewith@awaitNotRequired, so theunawaitedwrapper is dropped. The call is unchanged at runtime.matching_super_parametersin the showcase'sThemeModeController:ValueNotifier's positional parameter is now_value, so the super parameter takes that name. Writing: super(initial)instead tripsuse_super_parameters.lefthook run pre-push --all-filespasses on 3.47.5: format, analyze, tests, spell-check and the version-bump guard.Every sub-package passes
pub get, format and analyze, plus tests where it has them.Line coverage from
flutter test --coveragestays at 100%.The published showcase still builds with
--wasm.Not verified: the
very_good test --min-coverage 100gate itself, sincevery_good_cliis not installed locally. That is this pull request's own CI.The very_good_workflows references stay pinned at
v1.21.0, which also works on Dart 3.13. Dependabot's bump tov1.21.1becomes safe to accept once this merges.