Repository navigation
ci: pin the very_good_workflows jobs to a Dart 3.12 compatible release - #80
Merged
Merged
Conversation
very_good_workflows v1.21.1 moved the floating v1 tag to very_good_cli 1.5.0, which requires Dart ^3.13. Flutter 3.44.0, the version pinned in .fvmrc, ships Dart 3.12.0, so the build job fails at dependency install on every pull request. Pin flutter_package.yml to v1.21.0, which installs very_good_cli 1.4.0 (Dart ^3.12). Return to v1 once .fvmrc moves to a Flutter on Dart 3.13 or later.
license_check.yml at v1 also installs very_good_cli 1.5.0 on top of the Flutter from flutter_version, so it fails the same way as the build job whenever a pull request touches pubspec.yaml. Pin it to v1.21.0 with the build job, and move both back to v1 together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
buildjob fails at dependency install on every pull request, before any check runs:very_good_workflowsv1.21.1 moved the floatingv1tag tovery_good_cli 1.5.0, which requires Dart ^3.13. Flutter 3.44.0, the version in.fvmrc, ships Dart 3.12.0. The workflows hardcode the CLI version, so there is no input to override it.This pins the two reusable workflows that install the CLI to
v1.21.0, which installsvery_good_cli 1.4.0(Dart ^3.12):flutter_package.ymlinmain.yaml, which runs on every pull request.license_check.ymlinlicense_check.yaml, which runs only whenpubspec.yamlchanges, so a dependency or version bump would hit the same failure.semantic_pull_request.ymlandspell_check.ymlstay onv1, since they do not install the CLI.@v1together once.fvmrcmoves to a Flutter on Dart 3.13 or later (3.47+). A comment above each job records this.v1.21.1, which reintroduces the failure. That bump should be declined until the SDK moves.Checked: the
v1.21.0sources of both workflows installvery_good_cli 1.4.0, andvery_good_cliv1.4.0 declaressdk: ^3.12.0. This pull request toucheslicense_check.yaml, so its own CI runs both pinned jobs.Not verified: a green run of either pinned job. That is this pull request's own CI.