Added GUI to add polls - #2
Open
felixdngrs wants to merge 1 commit into
Open
felixdngrs wants to merge 1 commit into
felixdngrs wants to merge 1 commit into
Conversation
luckydonald
reviewed
May 14, 2023
| this.options.splice(index, 1); | ||
| }, | ||
| submit() { | ||
| // Hier muss der Code zum Speichern der Umfrage implementiert werden |
Member
There was a problem hiding this comment.
More specifically: An Axios request to our endpoint.
luckydonald
requested changes
May 14, 2023
Comment on lines
+20
to
+25
| axios | ||
| .get('/polls') // Hier wird die GET-Anfrage an den Server gesendet | ||
| .then(response => { | ||
| this.polls = response.data; // Hier wird die Antwort in der Datenliste gespeichert | ||
| }) | ||
| .catch(error => console.log(error)); |
Member
There was a problem hiding this comment.
better as async/await, otherwise a really good looking start!
Comment on lines
+4
to
+6
| import { library } from '@fortawesome/fontawesome-svg-core' | ||
| import { faHome, faTrash} from '@fortawesome/free-solid-svg-icons' | ||
| import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome' |
Member
There was a problem hiding this comment.
This should be in package.json and yarn.lock, just install it again with yarn add <package name>, and add those two files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.