connection_handler: resolve static server host via DNS - #3
Merged
Conversation
The static server (CONFIG_SNAPSERVER_HOST) was only run through ipaddr_aton(), which parses numeric IP literals, so a DNS hostname failed outright. Fall back to netconn_gethostbyname() when it is not a numeric IP, so the configured host may be a hostname resolved on the device network. Build-shim branch based on 1dfe76a (the commit the esphome integration pins); the upstream-master version of this fix is on nameresolution-addition. Assisted-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
|
Thanks! Did you test it?
You want to have this in the esphome component? Is there any change needed on the esphome side? |
Author
Of course, I'm using it as part of an esphome component on an esp32 - switched the fork/branch this PR is referencing and it works for me.
Can't say much about "outside of esphome", hence this PR targets the esphome component branch. |
Owner
|
Thanks, updated the esphome snapclient PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static server (CONFIG_SNAPSERVER_HOST) was only run through ipaddr_aton(), which parses numeric IP literals, so a DNS hostname failed outright. Fall back to netconn_gethostbyname() when it is not a numeric IP, so the configured host may be a hostname resolved on the device network.
Am I assuming correctly this change would - if accepted - go into the upstream branch "component"?