Repository navigation
Conversation
Owner
Author
🔀 Merge Summary
📁 Changed files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
--cwdvalidation spec was flaky in CI on POSIX runners.When CI relaxes trailing-slash validation, the test continued into target
directory resolution and failed on
stat /tmp/my-projectinstead ofasserting the intended validation behavior.
What
--cwdroot command spec to use a real temporarydirectory on POSIX runners
How
The test now creates a temporary directory for the POSIX invalid-path
case, strips the trailing slash via
filepath.ToSlash, and exercisesthe same command path under CI and local modes.
Breaking changes
Tests
go test ./cmdgo test -ldflags="-X github.com/louiss0/javascript-package-delegator/build_info.rawCI=true" ./cmdChecklist
go test ./...)develop(usegit flow feature start <name>)