Port remaining usage of Kotlin in generator and samples to Java - #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to simplify the project and reduce the number of dependencies. Modern Java offers many niceties that didn't exist when the project started, so the need for Kotlin is questionable.
This PR is an AI-assisted port to remove remaining usage of Kotlin from the generator and sample modules. The core module was already pure Java and so does not change.
In this project the validation of the port is easy, because it's mostly code generation and some (untouched) glue code in core. So it's easy to work in loops and verify that the resulting output code is identical to before the port.