fix(settings): keep machine-only capabilities out of Goal editor - #5034
Merged
Merged
Conversation
Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>
Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Opening Goal capabilities with the shared capability catalog showed machine-only settings such as Steward executor and Manager runtime as read-only Goal rows. The Goal editor now selects and navigates only capabilities declaring Goal scope. Goal-scoped read-only entries remain visible; machine-only settings remain in the Steward or machine settings that own them. No API or persisted configuration contract changes.
The browser fixture now supplies the same mixed catalog shape as the real Goal inspection endpoint, and the design guide records the ownership rule.
Visual review
Validation
npm run build(TypeScript, dashboard, packaged Chat bundle): passed.LOOPX_PERSONAL_WORKSPACE_SCENARIO=typed-actions node examples/personal-workspace-browser-smoke.mjs: passed.LOOPX_PERSONAL_WORKSPACE_PACKAGED=1: passed after rebasing onto current main.loopx checkon all four changed public paths: 0 errors; two unrelated existing Goal-state projection warnings.git diff --check origin/main...HEAD: passed.cqr_9c2acc4517c9ac583ba4, verified valid.Future-facing pass: reused the existing
available_scopesdescriptor and catalog components; no new scope state or backend duplicate was needed.