Skip to content

ci: give minimum Node qualification runner headroom #4836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 2 commits into from
Sep 21, 2026
Merged

ci: give minimum Node qualification runner headroom #4836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1892d7f
ci: give minimum Node lane runner headroom
huangruiteng Sep 20, 2026
5844978
Merge remote-tracking branch 'origin/main' into codex/minimum-node-ci…
huangruiteng Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_python_ci_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,18 @@ def test_checks_aggregate_requires_both_parallel_lanes(
assert (result.returncode == 0) == (kernel == dashboard == "success")


def test_minimum_node_lane_keeps_full_coverage_with_runner_headroom() -> None:
minimum = WORKFLOW.split(" node-minimum-compatibility:\n", 1)[1].split(
" node-forward-compatibility:\n", 1,
)[0]

assert "timeout-minutes: 15" in minimum
assert "for test in tests/control_plane_ts/*.test.ts" in minimum
assert 'node --no-warnings --experimental-sqlite --experimental-strip-types --test "${tests[@]}"' in minimum
assert "--test-name-pattern" not in minimum
assert "shard" not in minimum


@pytest.mark.parametrize("result", ["success", "failure", "cancelled", "skipped", ""])
def test_stage2c_gate_requires_all_lanes(result: str) -> None:
gate = WORKFLOW.split(" stage2c-correctness-e2e:", 1)[1].split(" windows-powershell:", 1)[0]
Expand Down
Loading