Skip to content

fix(replan): align vision semantics and qualify native agent closeout - #4730

Merged
huangruiteng merged 22 commits into
mainfrom
codex/replan-semantic-closeout
Sep 19, 2026
Merged

fix(replan): align vision semantics and qualify native agent closeout#4730
huangruiteng merged 22 commits into
mainfrom
codex/replan-semantic-closeout

test(replan): align blocked wait with vision writeback

2084d0a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Sep 19, 2026 in 3m 6s

Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 87 in loopx/control_plane/work_items/replan_semantics.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'patch.acceptance_summary ?? ""' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFzYQT3MxfJY-OFV&open=AaC5jFzYQT3MxfJY-OFV&pullRequest=4730

Check warning on line 954 in loopx/control_plane/testing/actual_default_model_behavior_portfolio.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "contract". 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFylQT3MxfJY-OFS&open=AaC5jFylQT3MxfJY-OFS&pullRequest=4730

Check warning on line 99 in loopx/control_plane/work_items/replan_semantics.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFzYQT3MxfJY-OFX&open=AaC5jFzYQT3MxfJY-OFX&pullRequest=4730

Check warning on line 88 in loopx/control_plane/work_items/replan_semantics.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'path.outcome ?? ""' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFzYQT3MxfJY-OFW&open=AaC5jFzYQT3MxfJY-OFW&pullRequest=4730

Check warning on line 39 in loopx/control_plane/work_items/replan_semantics.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'object(trigger).kind ?? ""' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFzYQT3MxfJY-OFU&open=AaC5jFzYQT3MxfJY-OFU&pullRequest=4730

Check warning on line 205 in tests/control_plane/test_required_vision_closeout_behavior.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jF1tQT3MxfJY-OFZ&open=AaC5jF1tQT3MxfJY-OFZ&pullRequest=4730

Check warning on line 68 in loopx/control_plane/testing/vision_shell_host.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Filesystem Oracle via unsanitized user input in Handler.handle() 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFx8QT3MxfJY-OFR&open=AaC5jFx8QT3MxfJY-OFR&pullRequest=4730

Check warning on line 193 in tests/control_plane/test_required_vision_closeout_behavior.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jF1tQT3MxfJY-OFY&open=AaC5jF1tQT3MxfJY-OFY&pullRequest=4730

Check failure on line 115 in loopx/control_plane/testing/replan_semantic_action_behavior.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFc-QT3MxfJY-OFM&open=AaC5jFc-QT3MxfJY-OFM&pullRequest=4730

Check failure on line 1339 in loopx/control_plane/testing/replan_semantic_action_behavior.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFc-QT3MxfJY-OFO&open=AaC5jFc-QT3MxfJY-OFO&pullRequest=4730

Check failure on line 49 in loopx/control_plane/testing/vision_shell_host.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure publicly writable directories are used safely here. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFx8QT3MxfJY-OFQ&open=AaC5jFx8QT3MxfJY-OFQ&pullRequest=4730

Check failure on line 113 in loopx/control_plane/testing/replan_vision_closeout_behavior.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 38 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFxUQT3MxfJY-OFP&open=AaC5jFxUQT3MxfJY-OFP&pullRequest=4730

Check failure on line 1233 in loopx/control_plane/testing/replan_semantic_action_behavior.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFc-QT3MxfJY-OFN&open=AaC5jFc-QT3MxfJY-OFN&pullRequest=4730

Check failure on line 1133 in loopx/control_plane/testing/actual_default_model_behavior_portfolio.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaC5jFylQT3MxfJY-OFT&open=AaC5jFylQT3MxfJY-OFT&pullRequest=4730
View more details on SonarQubeCloud