Skip to content

refactor(turn): bind the advisory primary through the shared decision owner #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Sep 15, 2026
Merged

refactor(turn): bind the advisory primary through the shared decision owner #4450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions loopx/cli_commands/turn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,14 @@
build_lark_operator_inbox_urgency_projector,
dispatch_goal_lark_turn_start_hooks,
)
from .turn_decision import apply_controller_advisory_primary
from .turn_dsh_host import build_dsh_host_runner
from .turn_registration import register_turn_commands as register_turn_commands
from .turn_inspection import handle_turn_journal_inspection
from .turn_rendering import (
render_loopx_turn_execution_markdown as _render_loopx_turn_execution_markdown,
render_loopx_turn_plan_markdown as _render_loopx_turn_plan_markdown,
)
from .turn_selection import turn_controller_advisory_primary
from .turn_todo_writeback import (
write_turn_repair_update,
write_turn_validated_completion,
Expand Down Expand Up @@ -183,22 +183,10 @@ def build_turn_decision(
goal_id=args.goal_id, agent_id=args.agent_id),),
)

decision = build_turn_decision()
controller_default = turn_controller_advisory_primary(decision)
if controller_default is not None:
primary_todo_id, advisory_portfolio = controller_default
decision = build_turn_decision(
requested_action_todo_id=primary_todo_id,
)
selected_todo = decision.get("selected_todo")
if not isinstance(selected_todo, dict) or (
selected_todo.get("todo_id") != primary_todo_id
):
raise ValueError(
"Turn controller advisory primary failed current eligibility"
)
selected_todo["selected_by"] = "turn_controller_advisory_primary"
decision["action_portfolio"] = advisory_portfolio
# `run-once` and `managed-step` must resolve the same governing decision,
# so the advisory-primary rebinding lives in the shared decision owner
# instead of being repeated per subcommand.
decision = apply_controller_advisory_primary(build_turn_decision)
resume_identity = {
"goal_id": args.resume_goal_id,
"agent_id": args.resume_agent_id,
Expand Down