Repository navigation
test(geojson): verify EMPTY MultiPoint rejection with spatial-types alpha.2 - #20
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=============================================
+ Coverage 99.65% 100.00% +0.34%
Complexity 156 156
=============================================
Files 14 14
Lines 287 287
=============================================
+ Hits 286 287 +1
+ Misses 1 0 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Alexandre-T
marked this pull request as ready for review
September 21, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #11. MultiPoint EMPTY-member rejection was implemented in #18, but spatial-types alpha.1 prevented constructing the real inputs needed to verify AC4/AC5. Requiring the approved 0.0.1-alpha.2 release enables eight explicit tests covering Geometry and Geography, XY and XYZ, mixed non-empty/EMPTY members and aggregates containing only EMPTY points.
Each test constructs real Point and MultiPoint objects before expecting UnsupportedGeometryStructureException from Writer. No fixtures bypass model invariants, and no runtime writer code changes are needed. Existing empty-aggregate tests continue to verify that zero members remain accepted. English strategy documentation and the test guide now describe the supported model and rejection behavior.
Validation with the declared alpha.2 dependency, using standard autoloading:
vendor/bin/phpunit --no-coverage --filter GeoJson: 112 tests, 438 assertions passed.composer test: 832 tests, 1210 assertions passed.composer quality: passed; existing PHPMD/PDepend deprecation notices remain. PHP CS Fixer required execution outside the sandbox for its local worker socket.git diff --check: passed.The serialization rule follows the already approved #11 contract for RFC 7946 MultiPoint geometries. No new normative interpretation or architecture decision is introduced. The exact dependency requirement changes from 0.0.1-alpha.1 to 0.0.1-alpha.2, explicitly approved by Alexandre; consumers must resolve alpha.2. Writer public APIs and serialization behavior remain unchanged, with no additional breaking change. vendor/ and the ignored composer.lock are not committed.
No reviewer was launched or requested, per Alexandre's instruction. Independent review and merge remain outstanding; story #11 is not marked Done.