Skip to content

fix: preserve authored library content before roadmaps - #151

Merged
Alexandre-T merged 4 commits into
mainfrom
149-story-preserve-authored-library-landing-page-content-before-generated-roadmaps
Oct 29, 2026
Merged

Alexandre-T merged 4 commits into
mainfrom
149-story-preserve-authored-library-landing-page-content-before-generated-roadmaps

Conversation

@Alexandre-T

@Alexandre-T Alexandre-T commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request

Summary

Library landing pages now retain their full authored body before generated roadmap content in HTML and portable Markdown. Regeneration refreshes only build-owned nodes without duplicating either part.

Related issue

Closes #149

Changes

  • Documentation content added or updated
  • Markdown generation updated
  • CI/CD or documentation tooling updated

Standards and references

  • Not applicable

No normative spatial behavior or architecture/API boundary is affected. The existing portable Markdown publication contract remains applicable.

Source and generated content

  • Source Markdown is valid and linted.
  • Generated content is consistent with its source.
  • Docusaurus builds successfully.
  • Internal links are valid.
  • Navigation and indexes are consistent.

Validation

  • Markdown lint passes.
  • Documentation build passes.
  • Generated resources have been checked.
  • Relevant links have been checked.
  • The rendered documentation has been visually reviewed.
  • CI passes.

Additional validation:

  • npm test: 451 passed, 1 optional Apache integration test skipped.
  • npm run build:local: passed; this invokes npm run build with the repository's fictional local legal configuration. Direct production build correctly refuses missing LEGAL_PUBLISHER_NAME.
  • PATH="$PWD/node_modules/.bin:$PATH" sh .githooks/pre-commit: 103 files, no issues.
  • git diff --check: passed.
  • Safari visual review of the published Spatial Types landing page confirmed the authored introduction before the timeline and table, with readable rendering.
  • Regression coverage includes rich authored AST nodes in both consumers, missing/empty/populated roadmaps, repeated generation, configuration updates, unchanged source files and excluded version pages. Export integration verifies portable references and fallback ordering.
  • composer test-local and composer quality: not applicable; this Node.js repository has no Composer configuration.

Documentation impact

Maintainer instructions now describe preservation and generated-content placement. Existing library landing page bodies become visible before their roadmap, fallback message and documentation-version links. No URLs or version landing page behavior change. Generated resources remain build outputs and source pages are never rewritten.

Checklist

  • The Pull Request has a clear and focused scope.
  • The related issue or Story acceptance criteria are satisfied.
  • Documentation terminology is consistent with the referenced standards.
  • Normative statements are traceable to their source when applicable.
  • No generated file was manually edited when it must be generated from a source.
  • No unrelated change is included.
  • Documentation impact was assessed; affected public behavior is documented, or the reason no update is needed is stated.
  • The Pull Request is ready for review.

@Alexandre-T Alexandre-T linked an issue Oct 29, 2026 that may be closed by this pull request
13 tasks

@Alexandre-T Alexandre-T left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

READY FOR MERGE

Targeted independent re-review of 4a60162 confirms that the previously reported inconsistencies are resolved:

  • The WKB landing page correctly describes Well-Known Binary (WKB).
  • Both WKB and WKT landing pages state security support until 31 December 2027, matching their 3.x JSON configurations and generated support tables.
  • A fresh npm run build:local succeeded, including publication verification (0 errors, 0 warnings). Assertions against all four rebuilt HTML/Markdown pages confirmed the corrected terminology, matching dates, absence of the superseded 2028 prose, and authored content before the generated timeline.
  • Markdown lint passed for 103 source files; git diff --check passed.
  • Current PR checks all pass: documentation-check, apache-negotiation, markdownlint and GitGuardian Security Checks.

The prior review verified the Story #149 implementation and independently ran 97 focused tests successfully. This latest commit only corrects the two landing pages. Reviewing the existing PR scope as requested, no blocking finding or unresolved decision remains. Applicable pre-merge Definition of Done requirements are satisfied. Merge and post-merge completion remain subject to Alexandre's decision.

@Alexandre-T
Alexandre-T merged commit eb37e9a into main Oct 29, 2026
6 checks passed
@Alexandre-T
Alexandre-T deployed to github-pages October 29, 2026 07:43 — with GitHub Actions Active
@Alexandre-T
Alexandre-T deleted the 149-story-preserve-authored-library-landing-page-content-before-generated-roadmaps branch October 29, 2026 07:43

This branch was successfully deployed

1 active deployment
github-pages — 4a601622 Deployed Oct 29, 2026 by Alexandre-T via deploy #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Story: Preserve authored library landing page content before generated roadmaps

1 participant