Skip to content

Implement instantiability classification - #8

Merged
Alexandre-T merged 2 commits into
mainfrom
6-determine-whether-a-geometry-type-is-instantiable
Sep 28, 2026
Merged

Alexandre-T merged 2 commits into
mainfrom
6-determine-whether-a-geometry-type-is-instantiable

Conversation

@Alexandre-T

@Alexandre-T Alexandre-T commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Closes #6

Summary

feat: Add volume geometry type
feat: Implement instantiability classification

Acceptance criteria

  • All acceptance criteria are implemented.

Validation

  • Relevant tests pass.
  • Repository quality checks pass.
  • Regression tests were added when fixing a bug.

Commands run

composer test
composer quality

Compatibility

  • No supported public API is affected.
  • Public API changes were explicitly approved.
  • No breaking change is introduced.
  • Breaking changes were explicitly approved.

Documentation

  • Documentation was updated where required.
  • No documentation change is required.

Developer handoff

Important implementation decisions

MULTICURVE is instantiable

Add volume geometry type and corresponding test
@Alexandre-T Alexandre-T self-assigned this Sep 28, 2026
@Alexandre-T Alexandre-T linked an issue Sep 28, 2026 that may be closed by this pull request
12 tasks done
@Alexandre-T
Alexandre-T force-pushed the 6-determine-whether-a-geometry-type-is-instantiable branch from 3205bbf to f75b29a Compare September 28, 2026 17:28
Implement instantiability classification for geometry types
@Alexandre-T
Alexandre-T force-pushed the 6-determine-whether-a-geometry-type-is-instantiable branch from f75b29a to b545e20 Compare September 28, 2026 17:30
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (305592e) to head (b545e20).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          197       205    +8     
=========================================
+ Hits           197       205    +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alexandre-T
Alexandre-T merged commit 978e449 into main Sep 28, 2026
4 checks passed
@Alexandre-T
Alexandre-T deleted the 6-determine-whether-a-geometry-type-is-instantiable branch September 28, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Story: Determine Whether a Geometry Type Is Instantiable

2 participants