Skip to content

ci: run checks only for pull requests - #40

Merged
Alexandre-T merged 1 commit into
mainfrom
fix/ci
Oct 12, 2026
Merged

Alexandre-T merged 1 commit into
mainfrom
fix/ci

Conversation

@Alexandre-T

Copy link
Copy Markdown
Contributor

Pull Request

Summary

Run PHP CI only for pull requests now that main and development branches prohibit direct pushes. Remove the decision job, push and scheduled triggers, and the unused pull-requests permission. Preserve the existing Markdown and LICENSE exclusions.

Acceptance criteria

  • All acceptance criteria are implemented: CI starts only on pull_request; the decision system is removed.

Validation

  • Relevant tests pass: 509 tests, 1,815 assertions, 100% line coverage.
  • Repository quality checks pass.
  • Regression tests: not applicable to this workflow-only change.
  • YAML parsing and trigger checks passed; git diff --check passed.
  • Existing PHPMD/PDepend deprecation notices appear under local PHP 8.5; quality checks exit successfully.

Commands run

composer test
composer quality
ruby -e 'require "yaml"; workflow = YAML.load_file(".github/workflows/ci.yml"); events = workflow.fetch("on", workflow[true]); abort "Unexpected triggers" unless events.keys == ["pull_request"]; abort "Decision job remains" if workflow["jobs"].key?("ci_decision"); puts "YAML valid; pull_request is the only trigger"'
git diff --check

Standards

  • No normative spatial behavior is affected.

Normative references

N/A

Architecture

  • No architectural boundary is affected.

Architecture decision

N/A

Compatibility

  • No supported public API is affected.
  • No breaking change is introduced.

Documentation

  • No documentation change is required.

Developer handoff

Important implementation decisions

The stable build now runs directly. Version matrix jobs retain their existing dependency on the stable build. Scheduled CI runs are removed to meet the pull-request-only requirement.

Compatibility considerations

Public PHP behavior is unchanged.

Remaining risks or questions

None.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0de0f30) to head (bee9903).

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #40   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       149       149           
===========================================
  Files             10        10           
  Lines            303       303           
===========================================
  Hits             303       303           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alexandre-T
Alexandre-T merged commit f632b5c into main Oct 12, 2026
17 checks passed
@Alexandre-T
Alexandre-T deleted the fix/ci branch October 12, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants