Fix vault data loss caused by destructive migration fallback - #2
Merged
Merged
Conversation
Co-authored-by: The-Young-Maker <66848791+The-Young-Maker@users.noreply.github.com>
…s to preserve vault data Co-authored-by: The-Young-Maker <66848791+The-Young-Maker@users.noreply.github.com>
Co-authored-by: The-Young-Maker <66848791+The-Young-Maker@users.noreply.github.com>
… integrity Co-authored-by: The-Young-Maker <66848791+The-Young-Maker@users.noreply.github.com>
Co-authored-by: The-Young-Maker <66848791+The-Young-Maker@users.noreply.github.com>
…ToV12 function Co-authored-by: The-Young-Maker <66848791+The-Young-Maker@users.noreply.github.com>
…t behavior Co-authored-by: The-Young-Maker <66848791+The-Young-Maker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with vaults disappearing after three days
Fix vault data loss caused by destructive migration fallback
Nov 5, 2025
loic-daigle
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User vaults were being deleted during app updates. Room's
.fallbackToDestructiveMigration()was configured to drop all tables when migrations failed or were missing, andMIGRATION_11_12was incomplete.Changes
Removed destructive migration
.fallbackToDestructiveMigration()from database builderAdded comprehensive migration coverage
migrateToV12function ensures consistent migration logic across all pathsFixed schema gaps
createdAtcolumn to vault table migrationsDEFAULT 0forreconciledcolumn in vault_contributions tableAll migrations now use idempotent SQL (
CREATE TABLE IF NOT EXISTS,PRAGMA table_infochecks) to safely handle existing schemas.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/gradle-daemon-main-8.13.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/agents/gradle-instrumentation-agent-8.13.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.13(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.