Add support for TLS settings - #35
Closed
slauger wants to merge 7 commits into
Closed
Conversation
Author
|
Hi, i just signed the CLA. Let me know if any further changes are necessary. |
Author
|
Any update or feedback? Is there anything i can do to increase the chance of merging? |
|
Is anyone available to look at this request? Having this support for the gelf output would be highly valuable. |
Author
|
I'm going to close this because i'm no longer working on this. Because of the poor support we decided to move away from logstash-output-gelf. We also had some performance issues with the GELF output. If anyone is interested feel free to "fork my fork". The main reason for this was to get our stuff from Logstash into our Graylog instance. We finally resolved this by putting a RabbitMQ instance between Logstash and Graylog (and using logstash-output-rabbitmq). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rubygem gelf library supports ssl since it's version 3.0.0. This PR adds new SSL options to logstash-output-gelf. This is pretty much a reimplementation of #28.
Parameters
Currently there is no option for ssl_ciphers as the gelf library dosen't have any kind of cipherlist option.
Please review and let me know if any changes are necessary.