Use .nil? for nil check - #29
Open
suhailpatel wants to merge 1 commit into
Open
Conversation
Author
|
I've signed the CLA but Github hasn't reflected it (https://www.elastic.co/contributor-agreement?license=icla).
|
Author
|
@jakelandis You seem to be the approver of PRs here, mind taking a look at this when you have a chance. I believe the bug is still present in the current versions |
|
@cwurm Hey :) Or somebody else, please merge this :) Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the metadata nil check uses
value == nil, unfortunately this causes issues with time fields and the time comparator with an exception:This modifies the code so the nil check is not an equality check but rather a Ruby
nil?check