Add -n/--tail support to lstk logs#359
Draft
gtsiolis wants to merge 1 commit into
Draft
Conversation
334bff0 to
0fe0c71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DevRel parity report: the Python CLI supports
localstack logs -n 20to inspect the last N log lines, whilelstk logsonly offered all-or-follow — cumbersome on a busy emulator and a migration papercut.-n, --tail(defaultall) is also the exact convention ofdocker logs,docker compose logs, andnerdctl logs.Changes
-n, --tailtolstk logs(string, default"all", wording identical todocker logs); validated at the command boundary — non-negative integer orallcontainer.Logs/ui.RunLogsintoruntime.StreamLogs, which previously hardcodedTail: "all"--follow --tail Nshows the last N lines and then streams (handled natively by the Docker API)MockRuntimefor theStreamLogssignature changeTail applies to raw log lines before the noise filter (docker semantics), so
--tail 20can display fewer than 20 lines unless-vis passed.Tests
--tail/-nlimit output, default shows all lines, invalid values are rejected with a helpful error, and--follow --tailstarts from the tail--tail 0,--tail all, over-count values, and combined-fn 3Closes PRO-358