Fix GitHub star link and exempt website PRs from release labels - #314
Merged
Merged
Conversation
mister-teddy
added
the
release:docs
mister-teddy
changed the title
mister-teddy
added
release:docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homepage's “Star us on GitHub” button linked to the restricted stargazers page, which returns 404 for logged-out visitors. Link it directly to the public repository.
The APK workflow also required a release label for website-only PRs, even though the release-management workflow already exempts them. Skip label validation and APK builds when every changed file is under gh-pages/. Renames from outside gh-pages/ remain subject to validation. Grant the validation job read access to PR metadata so it can list changed files.
This PR includes a workflow change, so it carries release:docs; future website-only PRs will need no release label.
Validation: exercised the actual classification script with 11 cases covering website-only, app, mixed, docs, fork, missing/multiple labels, empty file lists, renames, manual builds, and tag builds. All passed. git diff --check passed.