Skip to content

ci: upload PR APK artifacts directly #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mister-teddy merged 1 commit into from
Aug 11, 2026
Merged

ci: upload PR APK artifacts directly #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ jobs:
mv target/x/release/android/gradle/app/build/outputs/apk/debug/app-debug.apk target/x/localdesktop-${{ steps.extract_version.outputs.version }}-debug.apk
mv target/x/release/android/gradle/app/build/outputs/apk/release/app-release.apk target/x/localdesktop-${{ steps.extract_version.outputs.version }}.apk

- name: Compute PR APK artifact name
- name: Prepare PR APK artifact
id: pr_apk_artifact
if: github.event_name == 'pull_request'
env:
Expand All @@ -203,15 +203,18 @@ jobs:
SAFE_REF="pr-${PR_NUMBER}"
fi
SHORT_SHA="${HEAD_SHA:0:7}"
echo "name=localdesktop-${VERSION}-${SAFE_REF}-${SHORT_SHA}-release-apk" >> "$GITHUB_OUTPUT"
ARTIFACT_FILE="localdesktop-${VERSION}-${SAFE_REF}-${SHORT_SHA}-release.apk"
ARTIFACT_PATH="target/x/${ARTIFACT_FILE}"
cp "target/x/localdesktop-${VERSION}.apk" "$ARTIFACT_PATH"
echo "path=${ARTIFACT_PATH}" >> "$GITHUB_OUTPUT"

- name: Upload PR release APK
if: github.event_name == 'pull_request'
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: ${{ steps.pr_apk_artifact.outputs.name }}
path: target/x/localdesktop-${{ steps.extract_version.outputs.version }}.apk
path: ${{ steps.pr_apk_artifact.outputs.path }}
if-no-files-found: error
archive: false

- name: Build AAB
if: github.event_name != 'pull_request'
Expand Down
2 changes: 1 addition & 1 deletion gh-pages/docs/developer/1-how-to-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Then you will find the APK file in `target/x/release/android/localdesktop.apk`.

### Can I test a release-signed APK from a PR?

Yes. Same-repository PRs targeting `main` produce a signed release APK artifact when they have exactly one app-release label: `release:breaking`, `release:feature`, `release:bugfix`, `release:patch`, `release:improvement`, or `release:optimisation`. Download the workflow artifact from GitHub Actions and install it over the GitHub APK.
Yes. Same-repository PRs targeting `main` produce a signed release APK artifact when they have exactly one app-release label: `release:breaking`, `release:feature`, `release:bugfix`, `release:patch`, `release:improvement`, or `release:optimisation`. Download the `.apk` workflow artifact from GitHub Actions and install it over the GitHub APK. Older artifacts may still download as `.zip` files.

PRs labeled `release:docs` do not build an APK.

Expand Down
Loading