Skip to content

fix: [NovelBuddy] parseNovel method to include rating and fix genres - #2123

Merged
rajarsheechatterjee merged 2 commits into
lnreader:masterfrom
ig4e:patch-1
Apr 16, 2026
Merged

fix: [NovelBuddy] parseNovel method to include rating and fix genres#2123
rajarsheechatterjee merged 2 commits into
lnreader:masterfrom
ig4e:patch-1

Conversation

@ig4e

@ig4e ig4e commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)

No issues found

@ig4e
ig4e marked this pull request as ready for review April 15, 2026 11:19
Copilot AI review requested due to automatic review settings April 15, 2026 11:19
@ig4e ig4e changed the title Refactor parseNovel method to include rating and fix genres refactor: [NovelBuddy] parseNovel method to include rating and fix genres Apr 15, 2026
@ig4e ig4e changed the title refactor: [NovelBuddy] parseNovel method to include rating and fix genres fix: [NovelBuddy] parseNovel method to include rating and fix genres Apr 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the NovelBuddy plugin’s novel parsing to more robustly extract metadata (including rating) and to normalize genre output to the Plugin.SourceNovel contract.

Changes:

  • Bump NovelBuddy plugin version to 1.0.4.
  • Refactor parseNovel to normalize cover URLs/text, parse rating, and safely extract bookId from scripts.
  • Fix genre parsing to produce a comma-separated genre string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rajarsheechatterjee
rajarsheechatterjee merged commit 85065b9 into lnreader:master Apr 16, 2026
4 of 5 checks passed
nofzo pushed a commit to nofzo/lnreader-plugins that referenced this pull request May 22, 2026
…nreader#2123)

* Refactor parseNovel method, include rating and fix genres parsing

* Bump version from 1.0.3 to 1.0.4
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants