Update ALL ${ } usages across the file + feature requests 14, 25 & 26#27
Update ALL ${ } usages across the file + feature requests 14, 25 & 26#27DoktorShift wants to merge 14 commits into
Conversation
DoktorShift
requested review from
blackcoffeexbt,
riccardobl and
talvasconcelos
|
|
||
| try: | ||
| # Import lnurlp crud - may not be installed | ||
| from lnbits.extensions.lnurlp.crud import get_pay_links # type: ignore |
There was a problem hiding this comment.
import at the top of the file
inside the try/except
return if get_pay_links is undefined, on the endpoint!
|
Updated behaviour for mentioned Issue.
|
|
A few points from me:
What is the "lightning address" field for? |
- Rebase on upstream main (includes expiration fix, type strengthening, info event resend) - Sync uv.lock to match main (fixes mypy internal error with pydantic) - Reformat with black 25.1.0, prettier - Add type ignore for optional lnurlp import
DoktorShift
force-pushed
the
working_on_fr
branch
from
bf0c4ef to
c5b23d7
Compare
The pairing URL now encodes the relay with quote(), but the test NWCWallet client was using the encoded value directly to connect, causing 'scheme isn't ws or wss' errors.
| from .permission import nwc_permissions | ||
|
|
||
| try: | ||
| from lnbits.extensions.lnurlp.crud import ( # type: ignore[import-not-found] |
There was a problem hiding this comment.
we do not do imports between extensions, only calls via the API
| return lud16 && lud16.trim() ? lud16.trim() : null | ||
| }, | ||
| async showPairingDialog(secret, lud16) { | ||
| let url = `/nwcprovider/api/v1/pairing/${secret}` |
There was a problem hiding this comment.
The previous code used the placeholder {SECRET} with client-side replacement to avoid sending the secret to the server, this is changing that, unless it is a required change, I'd suggest reverting to the old behavior
| permissions=" ".join(data.permissions), | ||
| created_at=int(time.time()), | ||
| last_used=int(time.time()), | ||
| lud16=data.lud16, |
There was a problem hiding this comment.
should add some validation for lud16
| @@ -1,4072 +0,0 @@ | |||
| # This file is automatically @generated by Poetry 2.2.1 and should not be changed by hand. | |||
There was a problem hiding this comment.
i don't think this should be deleted
|
👍 — the Happy to give the merged change a real-device test against an LNBits instance running |
6 participants
Did a refactor to update ALL ${ } usages across the file to use v-text and remove delimiters entirely.
[Bug] Should display all connections by default #14 Default select the first Wallet when opening the extension
if a payer sends an LNURL comment (like "Thanks for the coffee!"), it will appear as the description in list_transactions. If no comment exists, it falls back to the payment memo, then to the BOLT11 invoice description.
instead of taking the name of receive wallet.