Avoid systemctl enable loop in installer by adding robust service helpers - #137
Open
arun-lmnas wants to merge 1 commit into
Open
Avoid systemctl enable loop in installer by adding robust service helpers#137arun-lmnas wants to merge 1 commit into
arun-lmnas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
systemctl enableservices in environments where systemd is not running or behaves differently (containers), so boot-time service enabling must be conditional.systemd-sysv-installactivity.Description
ENABLE_BOOT_SERVICES(defaultauto) andrunning_in_container/should_enable_boot_serviceshelpers so boot-time enabling is skipped automatically in containers.systemd_available,service_ctl,start_service,restart_service, andenable_servicehelpers to usesystemctlonly when available and fall back toserviceotherwise withtimeoutprotections.systemctl enable --nowandsystemctl restartcalls with the newstart_service/enable_service/restart_serviceflows formariadband the commonservicesstage.servicestatus/restart commands where appropriate so they work in non-systemd environments.Testing
bash -n install-frappe-press.shto validate shell syntax and it succeeded.git diff --checkto ensure there are no whitespace/patch problems and it succeeded.shellcheckbut it is not installed in this environment so automated linting was not performed.Codex Task