[CodeView] Require aggregates in getSizeInBytesForTypeRecord

[Nerixyz]

getSizeInBytesForTypeRecord returns the size of the CodeView leaf record for non-aggregates. It shouldn't be called with non-aggregates in the first place. This PR adds an assert and returns 0 in that case.
From a search here, it's only used in LVLogicalVisitor which already checks for tag records before calling this.

[llvmorg-github-actions]

@llvm/pr-subscribers-debuginfo

@llvm/pr-subscribers-platform-windows

Author: Nerixyz (Nerixyz)

Changes

getSizeInBytesForTypeRecord returns the size of the CodeView leaf record for non-aggregates. It shouldn't be called with non-aggregates in the first place. This PR adds an assert and returns 0 in that case.
From a search here, it's only used in LVLogicalVisitor which already checks for tag records before calling this.

---

Full diff: https://github.com/llvm/llvm-project/pull/218715.diff

1 Files Affected:

• (modified) llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp (+2-1)

diff --git a/llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp b/llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp
index 046b660abfab9..35acfcf18d175 100644
--- a/llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp
+++ b/llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp
@@ -177,6 +177,7 @@ uint64_t llvm::codeview::getSizeInBytesForTypeRecord(CVType CVT) {
   case LF_UNION:
     return getUdtSize<UnionRecord>(std::move(CVT));
   default:
-    return CVT.length();
+    assert(false && "not an aggregate");
+    return 0;
   }
 }