Skip to content

build_llvm_release.bat: Remove multiple ninja calls - #218702

Open
tstellar wants to merge 1 commit into
llvm:mainfrom
tstellar:build-llvm-simplify
Open

build_llvm_release.bat: Remove multiple ninja calls#218702
tstellar wants to merge 1 commit into
llvm:mainfrom
tstellar:build-llvm-simplify

Conversation

@tstellar

@tstellar tstellar commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

I think these were here to work around flaky tests, but the tests consistently pass now. Also, the script take a lot longer to complete when there are legitimate failures and it makes debugging problems much slower.

@tstellar
build_llvm_release.bat: Remove multiple ninja calls
1e72f6b 
I think these were here to work around flaky tests, but the tests
consistently pass now.  Also, the script take a lot longer to complete
when there are legitimate failures and it makes debugging problems much
slower.
@tstellar
tstellar requested review from c-rhodes, dyung, tru and zmodem August 25, 2026 14:54
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

🪟 Windows x64 Test Results

  • 140358 tests passed
  • 3711 tests skipped
  • 1 test failed

Failed Tests

(click on a test name to see its output)

Clang

Clang.Driver/msvc-link.c 
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --target=i686-pc-windows-msvc -fuse-ld=link -L/var/empty -L/usr/lib -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=BASIC C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --target=i686-pc-windows-msvc -fuse-ld=link -L/var/empty -L/usr/lib '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=BASIC 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 11
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --target=i686-pc-windows-msvc -shared -o a.dll -fuse-ld=link -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=DLL C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --target=i686-pc-windows-msvc -shared -o a.dll -fuse-ld=link '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=DLL 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 17
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --driver-mode=cl /Brepro -fuse-ld=link -### -- C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=REPRO C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --driver-mode=cl /Brepro -fuse-ld=link '-###' -- 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=REPRO 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 23
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --driver-mode=cl /Brepro- -fuse-ld=link -### -- C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=NOREPRO C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --driver-mode=cl /Brepro- -fuse-ld=link '-###' -- 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=NOREPRO 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 29
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --driver-mode=cl -fuse-ld=lld --vfsoverlay C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c -### -- C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=VFSOVERLAY C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --driver-mode=cl -fuse-ld=lld --vfsoverlay 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c' '-###' -- 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=VFSOVERLAY 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 35
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --target=arm64ec-pc-windows-msvc -fuse-ld=link -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64EC C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --target=arm64ec-pc-windows-msvc -fuse-ld=link '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64EC 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 36
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --driver-mode=cl --target=arm64ec-pc-windows-msvc -fuse-ld=link -### -- C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64EC C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --driver-mode=cl --target=arm64ec-pc-windows-msvc -fuse-ld=link '-###' -- 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64EC 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 37
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --driver-mode=cl -arm64EC -fuse-ld=link -### -- C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64EC C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --driver-mode=cl -arm64EC -fuse-ld=link '-###' -- 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64EC 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 40
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --target=arm64ec-pc-windows-msvc -fuse-ld=link -marm64x -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 |         c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64X C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --target=arm64ec-pc-windows-msvc -fuse-ld=link -marm64x '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64X 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 42
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --target=aarch64-pc-windows-msvc -fuse-ld=link -marm64x -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 |         c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64X C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --target=aarch64-pc-windows-msvc -fuse-ld=link -marm64x '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64X 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 44
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --driver-mode=cl -marm64x -fuse-ld=link -### -- C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64X C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --driver-mode=cl -marm64x -fuse-ld=link '-###' -- 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64X 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 45
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --driver-mode=cl -arm64EC -marm64x -fuse-ld=link -### -- C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64X C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --driver-mode=cl -arm64EC -marm64x -fuse-ld=link '-###' -- 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64X 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 48
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -fuse-ld= --target=arm64ec-pc-windows-msvc -marm64x -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64X-LLD C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -fuse-ld= --target=arm64ec-pc-windows-msvc -marm64x '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64X-LLD 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 49
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -fuse-ld= --target=aarch64-pc-windows-msvc -marm64x -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64X-LLD C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -fuse-ld= --target=aarch64-pc-windows-msvc -marm64x '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64X-LLD 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 50
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --driver-mode=cl -fuse-ld= -marm64x -### -- C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64X-LLD C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --driver-mode=cl -fuse-ld= -marm64x '-###' -- 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64X-LLD 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 51
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --driver-mode=cl -fuse-ld= -arm64EC -marm64x -### -- C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=ARM64X-LLD C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --driver-mode=cl -fuse-ld= -arm64EC -marm64x '-###' -- 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=ARM64X-LLD 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 55
not c:\_work\llvm-project\llvm-project\build\bin\clang.exe --target=x86_64-linux-gnu -marm64x -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=HYBRID-ERR C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: not 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --target=x86_64-linux-gnu -marm64x '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=HYBRID-ERR 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 58
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -S -marm64x  --target=arm64ec-pc-windows-msvc -fuse-ld=link -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 |         c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=HYBRID-WARN C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -S -marm64x --target=arm64ec-pc-windows-msvc -fuse-ld=link '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=HYBRID-WARN 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# RUN: at line 62
c:\_work\llvm-project\llvm-project\build\bin\clang.exe --target=i686-pc-windows-msvc -g -fuse-ld= -### C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe --check-prefix=DEBUG-LINK C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' --target=i686-pc-windows-msvc -g -fuse-ld= '-###' 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' --check-prefix=DEBUG-LINK 'C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c:66:20: error: DEBUG-LINK-NOT: excluded string found in input
# | // DEBUG-LINK-NOT: lld
# |                    ^
# | <stdin>:7:222: note: found here
# |  "C:\\BuildTools\\VC\\Tools\\MSVC\\14.44.35207\\bin\\Hostx64\\x86\\link.exe" "-out:a.exe" "-defaultlib:libcmt" "-defaultlib:oldnames" "-nologo" "-debug" "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\lit-tmp-lhlld6h4\\msvc-link-21f576.o"
# |                                                                                                                                                                                                                              ^~~
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\clang\test\Driver\msvc-link.c
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           1: clang version 24.0.0git (https://github.com/llvm/llvm-project a50fb2b9ea8d888df08b28751e2a488b347af561) 
# |           2: Target: i686-pc-windows-msvc 
# |           3: Thread model: posix 
# |           4: InstalledDir: C:\_work\llvm-project\llvm-project\build\bin 
# |           5: Build config: +assertions 
# |           6:  "C:\\_work\\llvm-project\\llvm-project\\build\\bin\\clang.exe" "-cc1" "-triple" "i686-pc-windows-msvc19.44.35228" "-emit-obj" "-dumpdir" "a-" "-disable-free" "-clear-ast-before-backend" "-main-file-name" "msvc-link.c" "-mrelocation-model" "static" "-mframe-pointer=all" "-relaxed-aliasing" "-fmath-errno" "-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases" "-fms-volatile" "-target-cpu" "pentium4" "-tune-cpu" "generic" "-gno-column-info" "-gcodeview" "-debug-info-kind=constructor" "-fdebug-compilation-dir=C:\\_work\\llvm-project\\llvm-project\\build\\tools\\clang\\test\\Driver" "-object-file-name=C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\lit-tmp-lhlld6h4\\msvc-link-21f576.o" "-fcoverage-compilation-dir=C:\\_work\\llvm-project\\llvm-project\\build\\tools\\clang\\test\\Driver" "-resource-dir" "C:\\_work\\llvm-project\\llvm-project\\build\\lib\\clang\\24" "-internal-isystem" "C:\\_work\\llvm-project\\llvm-project\\build\\lib\\clang\\24\\include" "-internal-isystem" "C:\\BuildTools\\VC\\Tools\\MSVC\\14.44.35207\\include" "-internal-isystem" "C:\\BuildTools\\VC\\Tools\\MSVC\\14.44.35207\\ATLMFC\\include" "-internal-isystem" "C:\\BuildTools\\VC\\Auxiliary\\VS\\include" "-internal-isystem" "C:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.26100.0\\ucrt" "-internal-isystem" "C:\\Program Files (x86)\\Windows Kits\\10\\\\include\\10.0.26100.0\\\\um" "-internal-isystem" "C:\\Program Files (x86)\\Windows Kits\\10\\\\include\\10.0.26100.0\\\\shared" "-internal-isystem" "C:\\Program Files (x86)\\Windows Kits\\10\\\\include\\10.0.26100.0\\\\winrt" "-internal-isystem" "C:\\Program Files (x86)\\Windows Kits\\10\\\\include\\10.0.26100.0\\\\cppwinrt" "-internal-isystem" "C:\\Program Files (x86)\\Windows Kits\\NETFXSDK\\4.8\\include\\um" "-ferror-limit" "19" "-fno-use-cxa-atexit" "-fms-extensions" "-fms-compatibility" "-fwrapv" "-fms-compatibility-version=19.44.35228" "-fskip-odr-check-in-gmf" "-fdelayed-template-parsing" "-faddrsig" "-o" "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\lit-tmp-lhlld6h4\\msvc-link-21f576.o" "-x" "c" "C:\\_work\\llvm-project\\llvm-project\\clang\\test\\Driver\\msvc-link.c" 
# |           7:  "C:\\BuildTools\\VC\\Tools\\MSVC\\14.44.35207\\bin\\Hostx64\\x86\\link.exe" "-out:a.exe" "-defaultlib:libcmt" "-defaultlib:oldnames" "-nologo" "-debug" "C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\lit-tmp-lhlld6h4\\msvc-link-21f576.o" 
# | not:66'0                                                                                                                                                            {                                                                                                 } search range (exclusive bounds)
# | not:66'1                                                                                                                                                                                                                                  !~~                           error: no match expected
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the infrastructure label.

zmodem
zmodem approved these changes Aug 25, 2026
View reviewed changes

@zmodem zmodem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was for flaky tests and flaky builds.

In particular, on my machine mt.exe would often fail to update a file right after linking, due to corporate antivirus getting in the way, which could break both regular builds and check-targets.

The consecutive ninja invocations was a hacky way to handle that, but if this is not an issue on the CI, removing them sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmodem zmodem zmodem approved these changes
@c-rhodes c-rhodes c-rhodes approved these changes
@dyung dyung Awaiting requested review from dyung
@tru tru Awaiting requested review from tru

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tstellar @zmodem @c-rhodes