[NFC][analyzer] Cleanup checker calls in ExprEngine::ProcessStmt, ExprEngine::Visit* - #218691
Open
tigbr wants to merge 31 commits into
Open
[NFC][analyzer] Cleanup checker calls in ExprEngine::ProcessStmt, ExprEngine::Visit*#218691tigbr wants to merge 31 commits into
ExprEngine::ProcessStmt, ExprEngine::Visit*#218691tigbr wants to merge 31 commits into
Conversation
These are handled by the same code and currently implemented inline in the switch, i.e. have no dedicated visit method.
`Expr::ObjCDictionaryLiteralClass`, `Expr::ObjCBoxedExprClass`, These are handled by the same code and currently implemented inline in the switch, i.e. have no dedicated visit method.
…tVisit` into the function `shouldJustCallCheckers` and also document status of each statement kind.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Begin standardizing how
PreStmtcheckers andPostStmtcheckers are called by the analyzer engine. Previously, checkers were called either fromExprEngine::Visitor the visit method of the statement. Now this logic was hoisted out intoExprEngine::ProcessStmtand most of the checker calls happen from there.There are several statement kinds that do not call checkers at all or only call
PreVisitor only callPostVisitcheckers. There are also statement kinds whose visit code does not easily lend itself to thePreVisit,Visit,PostVisitscheme, so those have been left unmodified and will be refactored in a separate patch. The checker calling status of statement kinds have been documented in the functionshouldJustCallCheckers.