Skip to content

Changes for kripke and its dependencies - #1368

Draft
rfhaque wants to merge 36 commits into
developfrom
kripke_upstream_spack
Draft

rfhaque wants to merge 36 commits into
developfrom
kripke_upstream_spack

Conversation

@rfhaque

@rfhaque rfhaque commented May 31, 2026 •

Copy link
Copy Markdown
Collaborator

This PR:

  • Adds throughput scaling parameters to the kripke experiment.py
  • Updates kripke spack package to use the latest develop version of RAJA, Umpire, CHAI and camp.
  • Adds the cxxstd variant to CHAI

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • Depends on Allocate and initialize memory on the GPU Kripke#76
  • If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.
  • Add/modify an experiments/benchmark_name/experiment.py to define an experiment

…aration to upstream to the spack-packages repository
@github-actions github-actions Bot added the experiment New or modified experiment label May 31, 2026
@github-actions github-actions Bot added the system New or modified system config label Aug 8, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.03%. Comparing base (3c75d75) to head (cc46409).

Files with missing lines Patch % Lines
experiments/kripke/experiment.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1368      +/-   ##
===========================================
+ Coverage    62.70%   64.03%   +1.33%     
===========================================
  Files           51       51              
  Lines         4073     4082       +9     
  Branches       356      357       +1     
===========================================
+ Hits          2554     2614      +60     
+ Misses        1489     1438      -51     
  Partials        30       30              
Files with missing lines Coverage Δ
experiments/kripke/experiment.py 22.58% <8.33%> (-1.95%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experiment New or modified experiment system New or modified system config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants