Skip to content

Accept documented groundTrack input forms - #148

Open
sylvesterkaczmarek wants to merge 1 commit into
llnl:mainfrom
sylvesterkaczmarek:fix/ground-track-list-inputs
Open

sylvesterkaczmarek wants to merge 1 commit into
llnl:mainfrom
sylvesterkaczmarek:fix/ground-track-list-inputs

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor

Summary

groundTrack() documents support for array_like positions and for a list of Orbit objects, but both forms currently fail before propagation: Python position lists reach _countR() without conversion to an ndarray, while lists of scalar orbits are misclassified as raw positions.

Normalize position inputs in _countR(), including a single three-vector, and route non-empty lists or tuples of Orbit objects through the existing _countOrbit() path. The existing deprecation warning for list-of-Orbit syntax is preserved.

Validation

Python 3.12 on macOS arm64:

  • New regressions on unchanged main (45730dc): 3 failed. After the fix: all 3 passed.
  • Focused compute suite: 20 passed.
  • Full suite: 337 passed, 2 skipped, 35 subtests passed.
  • py_compile and git diff --check passed.
  • Flake8 reports no new findings in the changed code; the pre-existing findings in compute.py and test_compute.py remain unchanged.

No propagator or coordinate-frame behavior changes for existing ndarray and Orbit inputs.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.39%. Comparing base (45730dc) to head (c5a8105).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files          17       17           
  Lines        5897     5902    +5     
=======================================
+ Hits         5743     5748    +5     
  Misses        154      154           
Flag Coverage Δ
unittests 97.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ssapy/compute.py 94.99% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvesterkaczmarek
sylvesterkaczmarek marked this pull request as ready for review September 20, 2026 02:48
@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor Author

This has been open for about 11 days with no maintainer feedback. The branch is current, mergeable, and all current checks are green. Could a maintainer review it when convenient?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants