Extract single-particle likelihoods explicitly in Linker - #145
Merged
SuperdoerTrav merged 1 commit intoSep 19, 2026
Merged
SuperdoerTrav merged 1 commit into
SuperdoerTrav merged 1 commit into
Conversation
sylvesterkaczmarek
marked this pull request as ready for review
September 19, 2026 08:56
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 17 17
Lines 5895 5895
=======================================
Hits 5737 5737
Misses 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks for merging this one too. I really appreciate the quick reviews and I’m glad to keep contributing to SSAPy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Particles.draw_orbit()returns a one-orbit list, soParticles.lnlike()returns a one-element array. Assigning that array directly tolnL[j]raisesValueError: setting an array element with a sequencewith NumPy 2.5.3, preventing the documentedLinker+Particlesworkflow from sampling track assignments.Extract the single likelihood explicitly with
np.asarray(...).item(). Existing scalar-returning likelihood providers remain supported. Probability normalization and the small-likelihood fallback are unchanged.Regression coverage uses real
Particlesobjects with a deterministic likelihood fixture, covering the first track, multiple model choices, and the existing small-likelihood fallback. No changes to orbit selection or propagation.Validation on Python 3.12 and NumPy 2.5.3:
main: 4 failed with the reported exception. After the fix: 4 passed.python -m pytest -q -n 2 --tb=shortreturned 310 passed, 2 skipped, and 35 subtests passed.linker.pyrelative to the base revision.git diff --checkpassed.