Preserve selected orbit roots during chained propagation - #144
Merged
SuperdoerTrav merged 1 commit intoSep 19, 2026
Merged
SuperdoerTrav merged 1 commit into
SuperdoerTrav merged 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 97.32% 97.39% +0.07%
==========================================
Files 17 17
Lines 5895 5897 +2
==========================================
+ Hits 5737 5743 +6
+ Misses 158 154 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sylvesterkaczmarek
marked this pull request as ready for review
September 19, 2026 08:46
Contributor
Author
|
Thanks for merging this as well. I really appreciate the continued review, and I’m glad to keep contributing to SSAPy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting from a vector returned by
Orbit.at()leaves_propagation_rootpointing to the full original vector. Calling.at()on the selected orbit then returns the whole collection. Reordering the vector also silently restores the original orbit order on the next propagation.Apply the same selection to vector propagation roots in
__getitem__and__next__. Keep scalar roots unchanged when selecting time samples of a single orbit.Regression tests cover integer and negative indexing, slices, reordering, boolean masks, iteration, and scalar-root time samples with Keplerian and RK4 propagators. Reproduced on current
mainat6af6000.Validation on Python 3.12:
python -m pytest -q -n 2 --tb=short: 324 passed, 2 skipped, 35 subtests passed.orbit.pycompared with the base revision.git diff --checkpassed.