Skip to content

Fix Particles fuse negligible-weight status - #142

Merged
SuperdoerTrav merged 1 commit into
llnl:mainfrom
sylvesterkaczmarek:fix/particles-fuse-status
Sep 19, 2026
Merged

SuperdoerTrav merged 1 commit into
llnl:mainfrom
sylvesterkaczmarek:fix/particles-fuse-status

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor

Summary

Fix the inverted verbose-status check in Particles.fuse().

Changes

  • Emit the negligible-weight warning only when reweight() reports failure.
  • Update the existing regression test to verify that successful reweighting is silent.
  • Add the corresponding failure-path assertion so the warning remains covered.

Testing

  • python3 -m py_compile ssapy/particles.py tests/test_particles.py
  • git diff --check

The local environment does not have the full SSAPy pytest dependency stack installed, so repository CI will provide the full test run.

Fixes #141

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.39%. Comparing base (a895a5b) to head (c743175).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files          17       17           
  Lines        5820     5820           
=======================================
  Hits         5668     5668           
  Misses        152      152           
Flag Coverage Δ
unittests 97.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ssapy/particles.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SuperdoerTrav
SuperdoerTrav merged commit 6e22ae8 into llnl:main Sep 19, 2026
5 checks passed
@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor Author

Thanks for merging this one as well. Much appreciated, and I’m looking forward to contributing more to SSAPy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Particles.fuse reports negligible weights after successful reweighting

3 participants