Make Orbit propkw equality and hashing consistent - #140
Merged
SuperdoerTrav merged 2 commits intoSep 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 17 17
Lines 5820 5829 +9
=======================================
+ Hits 5668 5677 +9
Misses 152 152
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Thank you for merging this. I really appreciate it, and I’m glad to keep contributing to SSAPy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
Orbitequality and hashing consistent for propagation keyword mappings.Changes
propkwkey sets before comparing values.NotImplementedwhen comparing anOrbitwith an unrelated type.propkwentries in sorted-key order so insertion order does not affect identity.propkwvalues before hashing, allowing ordinary scalar values such asarea=2.0.Testing
python3 -m py_compile ssapy/orbit.py tests/test_orbit.pygit diff --checkThe local environment does not have the SSAPy pytest dependency stack installed, so the repository CI will provide the full test run.
Fixes #139